Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance results for v1.32/vmware-vsphere-kubernetes-service #3563

Merged

Conversation

galop
Copy link
Contributor

@galop galop commented Jan 15, 2025

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • If this is a new entry, have you submitted a signed participation form?
  • Did you include the product/project logo in SVG, EPS or AI format?
  • Does your logo clearly state the name of the product/project and follow the other logo guidelines?
  • If your product/project is open source, did you include the repo_url?
  • Did you copy and paste the installation and configuration instructions into the README.md file in addition to linking to them?

For a full list of requirements, please refer to these sections of the docs: Contents of the PR, and Requirements.

Copy link

All requirements (15) have passed for the submission!

@taylorwaggoner
Copy link
Contributor

@galop thanks for submitting! Could you please provide more details for this:

Setup cluster according to the [documentation]

We ask for more detailed instructions for how to setup and configure clusters. Thanks!

@galop galop force-pushed the topic/conformance/kubernetes-v1.32.0 branch from c2406f7 to adcc859 Compare January 17, 2025 08:30
@galop
Copy link
Contributor Author

galop commented Jan 17, 2025

Hi @taylorwaggoner thanks for looking at the PR.

Actually the first line was misleading as the link takes user to prepare the vSphere environment for deployment. The instructions to deploy cluster are further ahead in the readme. I have updated the readme to clarify this by removing words setup cluster according to <link>.

Please review and let me know if any further changes are required. Thanks.

@taylorwaggoner
Copy link
Contributor

You are now Certified Kubernetes

@taylorwaggoner taylorwaggoner merged commit c6fbabc into cncf:master Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants